Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement I/O with CE polling system on JVM #3091

Closed
wants to merge 12 commits into from
Closed

Implement I/O with CE polling system on JVM #3091

wants to merge 12 commits into from

Conversation

armanbilge
Copy link
Member

Tries out:

So far I've done TCP sockets, still need to do unix and datagram sockets.

The SocketSuite passes for me locally, but not the TLSSocketSuite which revealed a bug using the polling system from blocking threads. After that's fixed I'd like to publish a snapshot for downstream test in Ember etc.

As with #3087, this PR is tangled up with #3063, so that will have to merge first.

@armanbilge armanbilge mentioned this pull request Dec 26, 2022
Merged
@armanbilge
Copy link
Member Author

Published 3.5-ac5c657.

@armanbilge
Copy link
Member Author

armanbilge commented Apr 21, 2023 •
edited
Loading

So after the update, TCP suite is passing, but TLS TCP suite is hanging.

A notable difference is that the TLS implementation uses blocking(...) and indeed the thread dump includes:

"io-compute-blocker-9" #32 daemon prio=5 os_prio=0 cpu=115.87ms elapsed=10.09s tid=0x00007f5f604e1680 nid=0x1
4d7 waiting on condition  [0x00007f5f3bffe000]
   java.lang.Thread.State: TIMED_WAITING (parking)
        at jdk.internal.misc.Unsafe.park(java.base@17.0.6/Native Method)
        - parking to wait for  <0x0000000725e008d0> (a java.util.concurrent.LinkedTransferQueue)
        at java.util.concurrent.locks.LockSupport.parkNanos(java.base@17.0.6/LockSupport.java:252)
        at java.util.concurrent.LinkedTransferQueue.awaitMatch(java.base@17.0.6/LinkedTransferQueue.java:676)
        at java.util.concurrent.LinkedTransferQueue.xfer(java.base@17.0.6/LinkedTransferQueue.java:616)
        at java.util.concurrent.LinkedTransferQueue.poll(java.base@17.0.6/LinkedTransferQueue.java:1294)
        at cats.effect.unsafe.WorkerThread.run(WorkerThread.scala:449)

Edit: oh, maybe that's just the blocker thread idling to see if it will be needed again, and otherwise a red herring 🤔

@armanbilge
Copy link
Member Author

Ok, so actually I can't reproduce the hanging on my macOS machine. Which makes me think it's something to do with epoll, and not kqueue? 🤔

This was referenced Apr 22, 2023
Open
Closed
@armanbilge
Copy link
Member Author

@durban your CE fix definitely helped things a lot, thanks. Unfortunately somehow one of the jobs still completely flaked on all the polling system stuff and then ended up hanging 🤔 at least this time it's not specific to TLS / blocking ...

https://github.com/typelevel/fs2/actions/runs/4816825621/jobs/8576820432?pr=3091#step:12:2466

@durban
Copy link
Contributor

durban commented Apr 27, 2023

I think I can sometimes (rarely) reproduce it locally. The WSTP is in an invalid state, although in a different way than before. I'll try to get details later.

@armanbilge
Copy link
Member Author

@armanbilge armanbilge closed this Jun 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@armanbilge @durban